Update central package versions - #4507
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3e8abd55-1508-4987-86d8-fd2401099e4c
paulmedynski
left a comment
There was a problem hiding this comment.
There is also Microsoft.Extensions.Hosting in the test CPM.
You will also need to update the SqlClient nuspec to advertise these updated dependencies.
Are we planning to update any other dependencies for 7.1, or just these few 9.0.x deps?
There was a problem hiding this comment.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Note
This error may be related to your runner configuration. You can now configure runners for Copilot code review separately from Copilot cloud agent by creating a copilot-code-review.yml file with your setup steps. Read the docs for details.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3e8abd55-1508-4987-86d8-fd2401099e4c
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (1)
Directory.Packages.props:106
- The PR description says the non-net9-compatible TFMs keep an "8.0.0" pin, but this file currently uses a mix of 8.0.0 and 8.0.1 (e.g., Microsoft.Extensions.Caching.Memory is 8.0.1). Please update the PR description to reflect the actual pinned versions (e.g., "8.0.x" / "existing 8.0.* pins") so it matches the change being reviewed.
<PackageVersion Include="Microsoft.Extensions.Caching.Memory" Version="9.0.18" />
</ItemGroup>
<ItemGroup Condition="!$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net9.0'))">
<PackageVersion Include="Microsoft.Extensions.Caching.Memory" Version="8.0.1" />
No more updates for 7.1, the next update on Azure deps will be for 8.0 milestone. |
paulmedynski
left a comment
There was a problem hiding this comment.
I think we still need SqlClient nuspec changes for these updated deps.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4507 +/- ##
==========================================
- Coverage 64.71% 62.77% -1.95%
==========================================
Files 288 283 -5
Lines 44088 67041 +22953
==========================================
+ Hits 28532 42082 +13550
- Misses 15556 24959 +9403
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Add missing System.Threading.RateLimiting dependency entries to the net462, net8.0, net9.0 and netstandard2.0 groups, and bump the net9.0 group to the 9.0.18 pins used by Directory.Packages.props. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3e8abd55-1508-4987-86d8-fd2401099e4c
Description
This PR updates the centrally managed package versions in
Directory.Packages.propsfor the .NET 9-compatible dependency set and aligns the generated package dependency metadata insrc/Microsoft.Data.SqlClient/src/Microsoft.Data.SqlClient.nuspecwith those target-framework-specific versions.The change keeps
Microsoft.Extensions.Caching.Memory,Microsoft.Bcl.Cryptography,System.Threading.RateLimiting,System.Configuration.ConfigurationManager, andSystem.Security.Cryptography.Pkcsaligned on9.0.18fornet9.0, while preserving the existing8.0.0/8.0.1pins for non-net9-compatible target frameworks. It also addsSystem.Threading.RateLimitingto the nuspec dependency groups so the packaged dependency metadata matches the project references.Issues
N/A
Testing
Microsoft.Data.SqlClientfornet8.0net8.0nuget.orgfor the updated dependency setGuidelines