feat: polish tools and session UI - #76
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces relative time formatting helpers, dynamic table column layouts, and an improved tool call status badge, along with comprehensive unit tests. The feedback highlights a critical performance optimization: caching the Intl.DateTimeFormat and Intl.RelativeTimeFormat instances at the module level to prevent expensive re-instantiations during table renders.
teedole
left a comment
There was a problem hiding this comment.
Addressed review findings; inline replies include the implementation and validation evidence.
|
Validator follow-up complete at signed tip c670831.
Evidence: focused UI suites and adversarial re-review clean; combined #73-#79 gate 781/781 plus TypeScript, Biome, distribution smoke, and headed desktop/mobile rendering. |
c670831 to
b420045
Compare
Summary
is_error = nullintentionally maps to Unknown. The archive does not expose an independent pending state, so presenting Pending would invent information.Why
The Tools page could widen unpredictably around long MCP names, tool outcomes were ambiguous, session rows lost useful date context, and clicks inside report/share dialogs could bubble into their dismissal backdrops.
Validation
just checkpasses: 658 tests, TypeScript, Biome, and the darwin-arm64 distribution staging smoke.Archive schema
The baseline is
LATEST_SCHEMA_VERSIONinsrc/db.ts. Check one: