Fix missed SSE pushes between snapshot and subscribe - #56
Merged
Conversation
(cherry picked from commit 0decbbd)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SSE handler subscribed to store notifications after sending the initial snapshot. An Add landing in that window was silently missed and only surfaced at the 15-second resync — the flaky TestSSEPushesOnAdd failure on #55's CI run was exactly this race under load.
Subscribing before taking the snapshot closes the window: an Add in between now shows up in the snapshot and additionally triggers one no-op flush.