Skip to content

Fix responsive width/height utilities overriding order #6840 #7428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Timo-Breumelhof wants to merge 1 commit into
base: develop
Choose a base branch
from
+9 −2
Open

Fix responsive width/height utilities overriding order #6840 #7428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions DNN Platform/Skins/Aperture/src/scss/utilities/_dimension.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,15 @@ $sizes: (
max-height: $value;
}
}
@each $breakpoint, $min-width in breakpoints.$breakpoints {
@media (min-width: $min-width) {
}

// Breakpoints must be the outer loop so that a larger breakpoint's rules
// always come later in the stylesheet than a smaller breakpoint's rules.
// Otherwise two !important rules from different breakpoints/sizes that are
// simultaneously active fall back to source order, and the wrong one wins.
@each $breakpoint, $min-width in breakpoints.$breakpoints {
@media (min-width: $min-width) {
@each $key, $value in $sizes {
.aperture-#{$property}-#{$breakpoint}-#{$key} {
@if ($property == 'w') {
width: $value !important;
Expand Down
Loading