Add tests for implicit conversions in Decisions, BKMs and DSs.#717
Open
opatrascoiu wants to merge 2 commits into
Open
Add tests for implicit conversions in Decisions, BKMs and DSs.#717opatrascoiu wants to merge 2 commits into
opatrascoiu wants to merge 2 commits into
Conversation
Contributor
|
@dmn-tck/contributors Please review |
SimonRinguette
approved these changes
May 21, 2026
yesamer
self-requested a review
May 21, 2026 12:20
yesamer
reviewed
Jun 18, 2026
| </testCase> | ||
|
|
||
| <testCase id="007" invocableName="To Singleton List DS" type="decisionService"> | ||
| <resultNode name="To Singleton List DS"> |
Contributor
There was a problem hiding this comment.
Raising the doubt that @AthiraHari77 raised in the original PR
Hi @opatrascoiu, we need a clarification regarding tests 007, 008, and 009 related to decisionService.
In these tests, the resultNode name has been set to the same value as the
invocableName, which corresponds to the decisionService name. Could you please
confirm whether the expected value for resultNode should be the decision name
itself, or the decisionService name?
Contributor
Author
There was a problem hiding this comment.
@yesamer Well spotted! Thank you for reviewing the PR. The name of resultNodes must be the name of the outputDecision. I pushed the fixes.
Contributor
|
@yesamer Please remember to review it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clone of PR #689 after rebase.