Skip to content

Add "Forbidden Mutation" and "Aggregate Share Request Rejected" docs - #196

Merged
jcjones merged 3 commits into
mainfrom
jcj/forbidden-fish-sauce
Aug 5, 2026
Merged

Add "Forbidden Mutation" and "Aggregate Share Request Rejected" docs#196
jcjones merged 3 commits into
mainfrom
jcj/forbidden-fish-sauce

Conversation

@jcjones

@jcjones jcjones commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Updates per divviup/janus#4766

Comment thread docs/references/janus-errors.md Outdated
Comment on lines +87 to +88
using the identifier but with different parameters. Retry under a new
identifier. (Note that re-sending the original request verbatim is always safe.)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not certain if "retry under a new identifier" is good advice. IMO attempting to mutate an existing resource likely indicates a very serious bug in an implementation that our documentation can't really help much with.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I took that advice out.

Comment thread docs/references/janus-errors.md Outdated
### Aggregate Share Request Rejected

A Janus helper has declined to produce an aggregate share for the requested
batch. It may be the case that the batch is old enough to be eligibile for

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/eligibile/eligible

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what a bileful mispelling

@jcjones
jcjones merged commit 3c1ee34 into main Aug 5, 2026
2 checks passed
@jcjones
jcjones deleted the jcj/forbidden-fish-sauce branch August 5, 2026 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants