refactor: Use comparison operator in comparison overloads - #2581
Open
rprospero wants to merge 4 commits into
Open
refactor: Use comparison operator in comparison overloads#2581rprospero wants to merge 4 commits into
rprospero wants to merge 4 commits into
Conversation
rprospero
marked this pull request as ready for review
August 20, 2026 15:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C++20 added the comparison operator (sometimes referred to as the spaceship operator), from which all of the other comparison operators can be derived. I've used this to cut down on a bunch of the boiler plate in our iterator overloads and for our
Numbertype.There's one change in the handling of NaN for the Number class. For any floating point value x, the following statements are always true under the new setup, but were always false under the old setup:
This was done to allow strong ordering of Number, despite floating point values only having weak ordering. This convention was chosen to preserve the the following three relations, which I considered more fundamental: