Skip to content

fix: Check parameter validity by type name #2577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trisyoungs merged 2 commits into from
Aug 11, 2026
Merged

fix: Check parameter validity by type name #2577

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab14c2d
Check parameter validity by name rather than (hashed) type.
trisyoungs Aug 10, 2026
c9b97ae
Add verbose comment.
trisyoungs Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/nodes/parameter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,8 +126,12 @@ class ParameterBase
// Get the parameter's value
template <typename DataClass> DataClass get()
{
// Requested DataClass must always match the storedDataType_, regardless of the underlying parameter type
if (std::type_index(typeid(DataClass)) != storedDataType_)
// Requested DataClass must always match the storedDataType_, regardless of the underlying parameter type.
// Note: We check by name() here rather than comparing type_index objects since, on OSX, it is possible for the same
// type to obtain different hash values within type_index (thus breaking comparison) if the object is only forward-
// declared rather than being fully in scope. There is no easy way around this, and it doesn't affect other platforms,
// so here we just revert to the name comparison.
if (std::type_index(typeid(DataClass)).name() != storedDataType_.name())
throw(std::runtime_error(std::format("ParameterBase::get() called with wrong type ({} vs {}), name = {}\n",
std::type_index(typeid(DataClass)).name(), storedDataType_.name(), name_)));

Expand All @@ -140,8 +144,9 @@ class ParameterBase
// Set the parameter's value
template <typename DataClass> void set(const DataClass &data)
{
// Requested DataClass must always match the storedDataType_, regardless of the underlying parameter type
if (std::type_index(typeid(DataClass)) != storedDataType_)
// Requested DataClass must always match the storedDataType_, regardless of the underlying parameter type.
// See note in ParameterBase::get() regarding choice of name() comparison.
if (std::type_index(typeid(DataClass)).name() != storedDataType_.name())
throw(std::runtime_error(std::format("ParameterBase::set() called with wrong type ({} vs {}), name = {}\n",
std::type_index(typeid(DataClass)).name(), storedDataType_.name(), name_)));

Expand Down
Loading