refactor: De-template Serialisable - #2535
Merged
Merged
Conversation
rprospero
approved these changes
Jun 29, 2026
rprospero
left a comment
rprospero
left a comment
Contributor
There was a problem hiding this comment.
It's outside the scope of this PR, but, since Serialisable is no longer a template class, we can more most of the method implementations into a corresponding cpp file and cut down on our compile time.
There's also come interesting things we could do, now that we're on C++20, where we make serialisable a concept instead of a class, but that is something to look at after Dissolve 2.0 is out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR takes the opportunity to remove the now-unnecessary context on
Serialisable, allowing it to be simplified down to a normalclasswith templated functions. I am hopeful that this, along with a liberal sprinkling of missingoverridespecifiers, will make the output on OSX builds terse enough to actually interpret.