fix(portfolio): restore mobile featured card actions - #81
Merged
Conversation
The Home featured Portfolio card was a plain block with h-full overflow-hidden, while its content div independently declared h-full. Without a flex container distributing height between the cover image and the content, height:100% on the content div resolved against the whole card instead of the space left after the image, pushing the mt-auto CTA past the card's clipped bottom edge. The action was present in the DOM with normal computed styles, just silently clipped by the ancestor's overflow-hidden. Makes the card a real flex column so the image and content share the available height, and lets the content div grow into the remaining space instead of re-claiming the full card height.
Locks the Home featured card's flex-column contract (card, cover wrapper, and content div classes) so the mt-auto CTA cannot silently regress back to being clipped by the card's overflow-hidden. Updates the no-JS marker baseline hash and literal-source assertion to match the corrected className.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
devrodri-com
marked this pull request as ready for review
August 7, 2026 06:06
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/and/en.h-full overflow-hidden, while its contentdivindependently declaredh-full. With no flex container distributing height between the cover image and the content,height:100%on the content div resolved against the whole card height instead of the space left after the image, pushing themt-autoCTA past the card's clipped bottom edge. The action was present in the DOM with normal computed styles (opacity:1,display:flex, correct color); it was purely clipped by an ancestor'soverflow-hidden.www.devrodri.com) at 390x844, 430x932, and 1440x1000 - reproduces on every breakpoint (not mobile-only) and on both/and/en. Not a PR fix(services): polish editorial widths and interactions #79/fix(nav): unify mobile navbar surface #80 regression:PortfolioSection.tsxhas been unchanged since 2026-08-04, well before either PR. Traced to PR feat(portfolio): feature LEM-BOX and ZENTRA #36 (13ef7c7, 2026-07-27, "feat(portfolio): feature LEM-BOX and ZENTRA"), which introduced the two-level image+content layout without making the card a flex container.flex flex-col, marks the image wrappershrink-0, and lets the contentdivgrow into the remaining space (flex-1 min-h-0) instead of re-claiming the full card height. No redesign, no Motion changes, no new dependencies./portfoliouses a different component (PortfolioCard.tsx) and is untouched.Test plan
npm run typechecknpm run lintnpm run test:run- 31 suites / 331 tests passing (330 baseline + 1 new regression lock)npm run build(client + server + prerender + verify:prerender + verify:http)npm run ci/portfoliorenders unaffected (different component)Note: WebKit verification via the iOS Simulator was blocked by a local Xcode configuration issue (
xcode-selectpointing at the wrong path), which needs asudocommand that could not be run here. Verification in this PR is Chromium-only; the fix is a plain CSS box-model correction (not an engine-specific quirk), and the physical iPhone + simulator screenshots that confirmed the original defect already show the same symptom this explains.🤖 Generated with Claude Code