Skip to content

test(climb): ola 4 — application funds/home con HttpGetPort#110

Merged
develop-iro merged 1 commit into
mainfrom
cursor/testing-climb-wave4-a459
Jul 16, 2026
Merged

test(climb): ola 4 — application funds/home con HttpGetPort#110
develop-iro merged 1 commit into
mainfrom
cursor/testing-climb-wave4-a459

Conversation

@develop-iro

Copy link
Copy Markdown
Owner

Summary

Continues the testing climb plan (docs/architecture/testing-climb-plan.md) with wave 4: application integration tests for funds / rankings / home services.

Production HTTP-backed services imported @/core/api/client, which pulls React Native and broke node:test. Same pattern as wave 3 storage ports:

  • Add HttpGetPort (src/core/api/http-get-port.ts)
  • Extract create*Service(deps) factories (no RN)
  • Keep thin production wrappers that bind real apiGet
  • Add createMemoryHttpGet() double + application specs

Coverage added

Service Specs
get-funds mock pages/filters, API parse + visibility, metrics fallback, blank search
get-rankings mock + API groups/cache/meta
get-fund-by-isin blank ISIN, API parse, 404 mock fallback
get-featured-funds mock carousel, API eligibility, API failure fallback
get-investment-news bundled headlines, API parse, fallback
resolve-home-search default / fund-match / assistant answer + disclaimer
load-compare-picker-funds mock sort + API search

Approximate counts after this wave: domain ~103 / application ~52 / contracts ~72 (pnpm run test:unit ≈ 227).

Test plan

  • pnpm run test:unit
  • tsc --noEmit
  • Merge after CI green; next wave is favorites/compare/calculator/feedback (ola 5)
Open in Web Open in Cursor 

Extrae factories create*Service con HttpGetPort para poder integrar
catálogo, rankings, ficha, destacados, noticias, home search y compare
picker en node:test sin cargar React Native. Añade createMemoryHttpGet
y specs de application; los wrappers de producción siguen cableando apiGet.
@develop-iro
develop-iro marked this pull request as ready for review July 16, 2026 18:15
@develop-iro
develop-iro merged commit 789f07b into main Jul 16, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants