test: User Management, Sort and Filter [CM-469] - #10158
Open
johnkim-det wants to merge 7 commits into
Open
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10158 +/- ##
==========================================
- Coverage 54.27% 54.26% -0.01%
==========================================
Files 1259 1259
Lines 157285 157291 +6
Branches 3644 3642 -2
==========================================
Hits 85359 85359
- Misses 71793 71799 +6
Partials 133 133
Flags with carried forward coverage won't be shown. Click here to find out more.
|
JComins000
reviewed
Oct 30, 2024
| }); | ||
| readonly username = new BaseComponent({ | ||
| parent: this, | ||
| selector: '[class^="Nameplate_text"] div:last-child', |
Contributor
There was a problem hiding this comment.
webui/react/src/e2e/models/common/hew/Nameplate.ts
JComins000
reviewed
Oct 30, 2024
| await userManagementPage.table.table.headRow[columnId].pwLocator.click(); | ||
| }, | ||
| ), | ||
| ).toPass(); |
Contributor
There was a problem hiding this comment.
might want to consider a timeout on these. i dont remember the default but it might be infinite
JComins000
approved these changes
Oct 30, 2024
JComins000
left a comment
JComins000
left a comment
Contributor
There was a problem hiding this comment.
requesting some small changes but very good work. merge when you're ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
CM-469
Description
Adds test for Sorting and Filters users on User Management page. Also includes:
Test Plan
No manual testing required. Automated tests should pass.
Checklist
docs/release-notes/See Release Note for details.