WEB: 暖気処理のステータスが処理中から変化しないことがある - #2200
Merged
Merged
Conversation
- 暖気処理で発生した例外は Throwable でキャッチする - 例外をキャッチした場合、ステータスを FAILED に変更する
Contributor
There was a problem hiding this comment.
Pull request overview
本PRは Issue #2198「暖気処理中に Error 派生例外がスローされるとステータスが PROCESSING から変化しない」問題に対応し、ウォームアップ非同期タスクのエントリポイントで Throwable を捕捉して失敗時にステータスを FAILED に遷移させることで、処理中ステータスのまま取り残されるケースを防ぐものです。
Changes:
- ウォームアップ実行エントリポイントの例外捕捉を
Exception→Throwableに拡張 - 例外捕捉時にステータスを
FAILEDに変更する処理を追加 - 上記挙動をJavaDocへ追記
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
iplass-web/src/main/java/org/iplass/mtp/impl/web/WarmupStatusServlet.java:179
- [must]
catch (Throwable e)内でchangeStatus(FAILED)の取得/更新処理がServiceConfigrationExceptionなどの別例外を投げる可能性があり、その場合に元のThrowableがマスクされてしまいます(結果として原因調査が困難になり、ステータス更新にも失敗し得ます)。ステータス更新は別途 try/catch で保護してログに落とし、元の例外は必ず再スローしてください。併せて、instanceof後のキャストはパターンマッチングを使うとガイドラインに沿います。
} catch (Throwable e) {
logger.error("Warmup failed.", e);
ServiceRegistry.getRegistry()
.getService(WarmupService.class)
.changeStatus(WarmupStatus.FAILED);
yuichi-github
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2198 .
対応内容
動作確認・スクリーンショット(任意)
/warmupStatusを確認complete (200)になることを確認(status: COMPLETE)failed (500)になることを確認(status: FAILED)failed (500)になることを確認(status: FAILED)レビュー観点・補足情報(任意)