Skip to content

Fix integration support_level_header - #5488

Open
kamalq97 wants to merge 4 commits into
masterfrom
ciac-17642-integration-support-level-header-fix
Open

Fix integration support_level_header#5488
kamalq97 wants to merge 4 commits into
masterfrom
ciac-17642-integration-support-level-header-fix

Conversation

@kamalq97

@kamalq97 kamalq97 commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Related Issues

fixes: CIAC-17642

Description

Fixed an issue where the ST110 validation was incorrectly flagging valid supportlevelheader values (community, partner, developer, xsoar) as false positives in integration YMLs.

@kamalq97 kamalq97 self-assigned this Aug 10, 2026
@kamalq97
kamalq97 requested a review from a team as a code owner August 10, 2026 07:34
@kamalq97 kamalq97 added bug Something isn't working python Pull requests that update Python code labels Aug 10, 2026
@github-actions

github-actions Bot commented Aug 10, 2026

Copy link
Copy Markdown

🚫 SDK Nightly required

This PR modifies files that require the SDK Nightly pipeline to be run before it can be merged:

  • demisto_sdk/commands/content_graph/strict_objects/integration.py\

Required action:

  1. Run the SDK Nightly pipeline against this branch.
  2. Add a link to the nightly run in this PR's description.
  3. Add the nightly-run-passed label once the run has passed (or nightly-run-skipped if you have a documented reason not to run it, with reviewer approval).
Alternative: run a Content build instead of the full SDK Nightly (click to expand)

If your change is scoped (e.g. a single new validator or a small bug fix), you can run a Content build against this SDK branch instead of the full SDK Nightly pipeline. When your change is a new validator, make sure it is registered in the Content repo's validation_config.toml so the Content build's run-validations job picks it up via demisto-sdk validate -a (the -a "all files" mode is what run-validations uses; a -g "git-diff" run will not exercise your new validator on unchanged files). Once the Content build is green, add the nightly-run-passed label to satisfy this gate.

This check will re-run automatically when a label is added or removed.

@github-actions

Copy link
Copy Markdown

Changelog(s) in markdown:

  • Fixed an issue where the ST110 validation was incorrectly flagging valid supportlevelheader values (community, partner, developer, xsoar) as false positives in integration YMLs. #5488

@BEAdi BEAdi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good, you will need to connect this PR to a content PR (using a connecting infra branch, there is a skill in content-configuration that does this) in order to check that nothing broke and that uploading a pack to a tenant behaves the same way (change content items with different SupportLevels in the content PR that you opened and check that their installation on the machine is working in the build), and upload to a tenant (best is using the bypass url created in the PR) and install the pack in order to see that everything works the same way as before.

@coveralls

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 31367186250

Warning

No base build found for commit 6c94a6c on master.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 86.185%

Details

  • Patch coverage: 6 of 6 lines across 2 files are fully covered (100%).

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 59840
Covered Lines: 51573
Line Coverage: 86.18%
Coverage Strength: 1.72 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working python Pull requests that update Python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants