mixclient: Make jitter configurable.#3732
Draft
jholdstock wants to merge 1 commit into
Draft
Conversation
Accept the message and peer jitter durations as parameters to NewClient and Dicemix respectively, rather than hardcoding them as package constants. Allowing consumers to set jitter however they please makes the package more flexible. It also enables jitter to be set to zero in tests, which has a very dramatic impact. On my system with a i7-10750H CPU this reduces the total runtime for the mixclient package tests from ~143.4s to ~13.1s.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accept the message and peer jitter durations as parameters to NewClient and Dicemix respectively, rather than hardcoding them as package constants. Allowing consumers to set jitter however they please makes the package more flexible. It also enables jitter to be set to zero in tests, which has a very dramatic impact.
On my system with a i7-10750H CPU this reduces the total runtime for the mixclient package tests from ~143.4s to ~13.1s.
Note
This is a proof-of-concept just for feedback, and should be considered along with decred/dcrwallet#2641. This breaks the public API of the mixclient module so will need to be preceeded by a version bump before it can be merged. I'll open a PR for that if we want to proceed with this change.