Fix a couple of issues that deal with the RAiDER bias compared to GNSS - #805
Draft
jlmaurer wants to merge 20 commits into
Draft
Fix a couple of issues that deal with the RAiDER bias compared to GNSS#805jlmaurer wants to merge 20 commits into
jlmaurer wants to merge 20 commits into
Conversation
…f requests into one
Collaborator
Author
|
Changing this to draft until I verify the integration method. |
8 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR came about through comparing RAiDER-derived ZTD to GNSS ZTD and tracking down the source of the differences with the help of Claude Fable.
NOTE: This PR builds on #802; that PR should be integrated before this one.
Description
There were two funadmental changes needed, one of which was already in place but was not being called.
llreader.pyin Use memory efficiently, GNSS geometric heights #795 , but it was never called. This PR adds the needed infrastructure so that a user can specify a CRS for the GNSS station heights, and those will get converted to geoid heights.Motivation and Context
These two issues together all but eliminate the bias between GNSS and RAiDER ZTD estimates.
How Has This Been Tested?
Unit tests pass locally
The unit test for
getZTDbroke because it used a linear function to test. This PR changes the linear function to an exponential, since the new functionality assumes exponential decrease in hydrostatic delay with elevation.Screenshots (if appropriate):
Type of change
Checklist: