Add ResolvePlaces API, tabular place_dcids, and Spanner topic expansion - #2077
Open
keyurva wants to merge 3 commits into
Open
Add ResolvePlaces API, tabular place_dcids, and Spanner topic expansion#2077keyurva wants to merge 3 commits into
keyurva wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new V2AgentResolvePlaces RPC endpoint to resolve place name queries to canonical DCIDs, names, and types. It also refactors the SearchIndicators endpoint to support a tabular response format and accept explicit place_dcids directly, bypassing place resolution. Additionally, common helper functions and constants are refactored into a new util.go file. The review feedback suggests using the generated protobuf getter GetMetadata() instead of accessing the Metadata field directly in search_indicators.go for safer and more idiomatic code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ResolvePlacesendpoint in the agent service to resolve place names to DCIDs with 1:1 row alignment (including placeholder rows for unresolved queries).SearchIndicatorsto support tabularplace_dcidsinput, preserve input place ordering, and aggregate child topic place availability prior to topic pruning.SpannerDataSourcevector search resolution to expand topic candidates whenexpand_topics: trueis set.Verification
Tested locally as follows:
place_dcids& Topic Expansion: