Skip to content

Add V2 internal SDMX endpoints and remote data source support - #2073

Merged
keyurva merged 4 commits into
datacommonsorg:masterfrom
keyurva:sdmx-grpc
Jul 30, 2026
Merged

Add V2 internal SDMX endpoints and remote data source support#2073
keyurva merged 4 commits into
datacommonsorg:masterfrom
keyurva:sdmx-grpc

Conversation

@keyurva

@keyurva keyurva commented Jul 30, 2026

Copy link
Copy Markdown
Contributor
  • Defined internal V2 SDMX data and availability RPCs for inter-instance query federation.
  • Implemented server handlers for internal SDMX requests.
  • Added SDMX query delegation to the remote client and remote data source.

Manually tested by deploying to dev, and running mixer in dcp mode with the dev mixer as remote:

curl -X POST http://localhost:8081/v3/internal/sdmx/data \
  -H "Content-Type: application/json" \
  -d '{
    "constraints": {
      "variableMeasured": {
        "predicates": [{"value": "Count_Person"}]
      },
      "observationAbout": {
        "predicates": [{"value": "geoId/06"}]
      }
    }
  }' | jq .

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces internal SDMX endpoints (V3InternalSdmxData and V3InternalSdmxAvailability) to support structured SDMX data and availability queries from remote mixers. It updates the protobuf definitions, implements the server handlers, adds remote client support, and integrates these into the remote data source. Unit tests are also added to verify that requests are correctly forwarded. There are no review comments, and I have no feedback to provide.

@keyurva
keyurva requested a review from rohitkumarbhagat July 30, 2026 01:09

@rohitkumarbhagat rohitkumarbhagat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Keyur!!

Comment thread internal/proto/sdmx/sdmx.pb.go
Comment thread proto/service/mixer.proto Outdated
Comment thread internal/server/remote/client.go Outdated
@keyurva keyurva changed the title Add V3 internal SDMX endpoints and remote data source support Add V2 internal SDMX endpoints and remote data source support Jul 30, 2026
@keyurva
keyurva enabled auto-merge July 30, 2026 17:56
@keyurva
keyurva added this pull request to the merge queue Jul 30, 2026
Merged via the queue into datacommonsorg:master with commit 83d97f9 Jul 30, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants