Skip to content

Reapply "Add per-provenance counters to dataflow and spanner" - #697

Merged
vish-cs merged 2 commits into
datacommonsorg:masterfrom
vish-cs:observability
Jul 30, 2026
Merged

Reapply "Add per-provenance counters to dataflow and spanner"#697
vish-cs merged 2 commits into
datacommonsorg:masterfrom
vish-cs:observability

Conversation

@vish-cs

@vish-cs vish-cs commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Revert PR #694 and reapply per-provenance counters #658

This reverts commit e282635.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 13 complexity

Metric Results
Complexity 13

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@vish-cs vish-cs changed the title Reapply "Add per-provenance counters to dataflow and spanner (#658)" … Reapply "Add per-provenance counters to dataflow and spanner" Jul 30, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces per-import metric tracking for the graph ingestion pipeline, updating the Java pipeline to pass import-specific counters, parsing these metrics from Dataflow in the Python helper, and writing them to Spanner's ImportVersionHistory table. It also changes the lock acquisition failure status code to 503 and adds corresponding unit tests. A review comment identified a bug in imports.py where per-import metrics are overwritten instead of accumulated using +=, which could lead to undercounting across multiple Dataflow steps.

Comment thread pipeline/workflow/ingestion-helper/utils/imports.py Outdated
@vish-cs
vish-cs requested a review from SandeepTuniki July 30, 2026 04:32
@vish-cs
vish-cs enabled auto-merge (squash) July 30, 2026 04:34
@vish-cs
vish-cs merged commit 8383780 into datacommonsorg:master Jul 30, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants