Reapply "Add per-provenance counters to dataflow and spanner" - #697
Conversation
…monsorg#658)" (datacommonsorg#694) This reverts commit e282635.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 13 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Code Review
This pull request introduces per-import metric tracking for the graph ingestion pipeline, updating the Java pipeline to pass import-specific counters, parsing these metrics from Dataflow in the Python helper, and writing them to Spanner's ImportVersionHistory table. It also changes the lock acquisition failure status code to 503 and adds corresponding unit tests. A review comment identified a bug in imports.py where per-import metrics are overwritten instead of accumulated using +=, which could lead to undercounting across multiple Dataflow steps.
…dercounting across multiple step entries
Revert PR #694 and reapply per-provenance counters #658
This reverts commit e282635.