Remove redundant pre-existing linked edge filtering in LinkedEdgeGenerator - #687
Merged
Merged
Conversation
…rator Because AggregationOrchestrator invokes AggregationDeleter to delete all existing generated edges for active imports before calculations run, querying Spanner for existing linked edges and filtering against them in LinkedEdgeGenerator is redundant. Removing this filtering eliminates three global federated queries from BigQuery to Spanner on every pipeline run.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request simplifies the SQL queries in linked_edge_generator.py by removing the logic that pulls and filters out existing generated edges (such as linkedMemberOf, linkedContainedInPlace, and linkedMember). Instead, the queries now directly return the newly generated edges (NewEdges). There are no review comments provided, and I have no additional feedback on these changes.
vish-cs
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes some old code around pre-filtering of existing linked edges. This is no longer necessary as we now have a separate deletions step that runs before any aggregations.