Skip to content

[DCP] Set the force restarts as a TF Variable - #201

Open
gmechali wants to merge 2 commits into
mainfrom
forceRestart
Open

[DCP] Set the force restarts as a TF Variable#201
gmechali wants to merge 2 commits into
mainfrom
forceRestart

Conversation

@gmechali

Copy link
Copy Markdown
Contributor

This will allow us to speed up development by preventing over 3 minutes of wait time on every TF apply.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a force_restart boolean variable across the Terraform modules to conditionally control whether Cloud Run services are forced to redeploy/restart with a timestamp. The review feedback suggests setting the top-level variable default to null and configuring the innermost module's default to false to ensure nested module defaults are respected and not overridden by parent defaults.

Comment thread infra/dcp/variables.tf Outdated
Comment thread infra/dcp/modules/ingestion/helper_service/variables.tf Outdated
@gmechali

Copy link
Copy Markdown
Contributor Author

/gemini review

@gmechali
gmechali requested a review from clincoln8 July 31, 2026 01:43

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new Terraform variable skip_container_restarts (defaulting to false) across several modules. When set to true, it prevents updating the FORCE_RESTART environment variable with a new timestamp, thereby avoiding unnecessary container restarts and speeding up terraform apply when container images have not changed. I have no feedback to provide as there are no review comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant