Add profiler correctness tests for Redshift and Synapse - #2569
Open
nnigam19 wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2569 +/- ##
=======================================
Coverage 69.50% 69.50%
=======================================
Files 107 107
Lines 9626 9626
Branches 1065 1065
=======================================
Hits 6691 6691
Misses 2734 2734
Partials 201 201 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
❌ 219/220 passed, 45 flaky, 1 failed, 2 skipped, 15m20s total ❌ test_redshift_provisioned_profiler_extract_is_correct: AssertionError: Column mismatch for table 'rs_avg_queries_minute' (6.914s)Flaky tests:
Running from acceptance #5059 |
m-abulazm
requested changes
Jul 27, 2026
m-abulazm
left a comment
m-abulazm
left a comment
Contributor
There was a problem hiding this comment.
I would prefer e2e tests that are more future proof. I would test the entry point Profiler instead of testing internal profiler components. at the beginning we can keep the assertions minimal. dont assert columns, it can be that it ran and terminated successfully, start with redshift and sqlserver as synapse secrets are not there yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the first profiler-correctness tests, following review feedback that the
suite should validate profiler correctness, not just that the pipeline engine
runs. Test-only, no production changes.
test_profiler_correctness_redshift.py(integration) - runs the realRedshift provisioned profiler queries against the live Redshift sandbox and
asserts the DuckDB extract has no stray tables, the always-produced tables are
present, and each produced table has exactly the expected column set. Skips
when
REDSHIFT_*creds are absent (runs in CI).test_profiler_correctness_synapse.py(integration) - runs the realSynapse metadata extract queries (
INFORMATION_SCHEMA: tables/columns/views/routines) against the SQL Server sandbox stand-in and asserts each result
ingests into its pinned
SYNAPSE_SCHEMASshape. Skips whenTEST_TSQL_*credsare absent (runs in CI).
test_synapse_schema_contract.py- validates everySYNAPSE_SCHEMASdeclaration is valid DuckDB DDL producing exactly the declared columns and
types. Needs no creds.
profiler_extract_helpers.py- shared, non-test helpers (schema parsing,DuckDB inspection, env gating) used by the above.
Testing
test_synapse_schema_contract.py: 41 cases, all passing locally.without creds, they exercise their live sandboxes in CI, where their exact
column/schema expectations get their first live validation.
Known gaps (follow-ups)
info, monitoring metrics, SQL-pool enumeration) and
SYS.DM_PDW_*activityextracts require a real Synapse workspace and are not covered.
credentials.