feat(ui): split external Send into address, From, and amount steps#847
Open
romchornyi wants to merge 1 commit into
Open
feat(ui): split external Send into address, From, and amount steps#847romchornyi wants to merge 1 commit into
romchornyi wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The redesigned Send form showed the numeric keypad and amount entry on the address step. Split it into three screens — address (SendScreen), source picker (SendSourceScreen), and amount — and choose the amount step by the resolved route: - Core → Core continues into the existing classic L1 amount screen (real fee math + its own confirm) via performPay, so there is no double amount entry. - Every other leg the L1 screen can't fund — the Core → Shielded asset-lock shield and all Platform/Shielded sources — uses the custom amount screen (ExternalSendAmountScreen) + SendConfirmSheet. The chain-sync gate blocks Continue on the From step; balance/affordability checks stay on the amount step. Both hosts push the steps through shared pushExternalSendSource / pushExternalSendAmount extensions, mirroring pushInternalTransfer.
romchornyi
force-pushed
the
fix/send-split-address-amount-steps
branch
from
July 17, 2026 17:22
ee980be to
48c9827
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
The redesigned external Send form (introduced in #819) showed the numeric keypad and amount entry on the address step, and again a second time on the classic amount screen for a plain Core → Core send. The address, source, and amount were not cleanly separated.
What was done?
Split the flow into three screens — address → From → amount:
SendScreen) — address field + destination-type badge + invalid-address / source-mismatch validation, clipboard suggestion, and Scan QR.Continueis gated by the newSendViewModel.canAdvanceToAmount. No keypad, no amount.SendSourceScreen) — source picker only (Transparent / Platform / Shielded), with a read-only address summary and the chain-sync gate note. No amount.performPay— no double amount entry.ExternalSendAmountScreen+SendConfirmSheet.Validations preserved: the chain-sync gate (
isBlockedBySync/SyncGateNote) blocksContinueon the From step for Core-funded legs; balance/affordability checks (canContinue) stay on the amount step. Routing under the hood is unchanged. Both hosts push the steps through sharedpushExternalSendSource/pushExternalSendAmountextensions, mirroringpushInternalTransfer; the three screens share oneSendViewModel.How Has This Been Tested?
Clean
dashpaybuild (xcodebuild ... -scheme dashpay -sdk iphonesimulator ARCHS=arm64 build). Not yet smoke-tested on testnet across every route — needs a manual pass: Core→Core into the classic amount screen; Core→Shielded / Platform / Shielded into the custom amount screen + confirm; and the balance-row send sheet's Send tab.Breaking Changes
None.
Checklist:
For repository code-owners and collaborators only