Skip to content

fix(http2): reject server push when disabled - #1966

Merged
brianquinlan merged 2 commits into
dart-lang:masterfrom
brianquinlan:serverpush
Aug 20, 2026
Merged

fix(http2): reject server push when disabled#1966
brianquinlan merged 2 commits into
dart-lang:masterfrom
brianquinlan:serverpush

Conversation

@brianquinlan

@brianquinlan brianquinlan commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator
  • Treat incoming server push streams as connection protocol error when pushes are disabled (SETTINGS_ENABLE_PUSH=0). This is a RFC 7540 requirement.

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Note: The Dart team is trialing Gemini Code Assist. Don't take its comments as final Dart team feedback. Use the suggestions if they're helpful; otherwise, wait for a human reviewer.

# Conflicts:
#	pkgs/http2/CHANGELOG.md
@brianquinlan
brianquinlan merged commit a0d49cb into dart-lang:master Aug 20, 2026
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants