Skip to content

Fix Stump not displaying thumbnails#1

Merged
ahze merged 4 commits into
daemonless:mainfrom
jtrotsky:thumbnailfix
Jul 19, 2026
Merged

Fix Stump not displaying thumbnails#1
ahze merged 4 commits into
daemonless:mainfrom
jtrotsky:thumbnailfix

Conversation

@jtrotsky

@jtrotsky jtrotsky commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Noticed Stump was not displaying thumbnails, looking into it there was a security change for http headers plus a flag for reverse proxies.

So added the flag commented out + docs update.

Also set:

  • category to Media Servers (was Books which doesnt exist)
  • community to the Stump Discord (was this discord)

Tests:

  • dbuild test
  • dbuild build
  • dbuild generate

@jtrotsky

Copy link
Copy Markdown
Contributor Author

@ahze one thing i wasn't sure of was the community tag. Should it be always daemonless Discord or the upstream?

@ahze

ahze commented Jul 18, 2026

Copy link
Copy Markdown
Member

@ahze one thing i wasn't sure of was the community tag. Should it be always daemonless Discord or the upstream?

good question - it was originally set up for daemonless discord or if someone setup a 'daemonless' clone, they could use their own community link. I never even thought to consider external community links.

Lets do discuss using them somehow, but I think for now, community should be internal?

@jtrotsky

jtrotsky commented Jul 18, 2026

Copy link
Copy Markdown
Contributor Author

Lets do discuss using them somehow, but I think for now, community should be internal?

@ahze agreed. The "community" description is about getting help, and if someone genuinely needs help with this Stump image the daemonless Discord is the best place..

Have updated

Comment thread Containerfile Outdated
LABEL org.opencontainers.image.title="Stump" \
org.opencontainers.image.description="A free and open source comics, manga and digital book server with OPDS support." \
org.opencontainers.image.source="https://github.com/daemonless/stump" \
org.opencontainers.image.source="https://github.com/daemonless/stump-daemonless" \

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change back to daemonless/stump. - should I make it so dbuild does a better job at this?

@jtrotsky jtrotsky Jul 19, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah it regularly catches me when im working from a fork. I forget to put DBUILD_REGISTRY=ghcr.io/daemonless (I think this time i accidentally wrote github.com/daemonless 🤦 )

Happy if you can improve it, but i'm ok otherwise

@ahze

ahze commented Jul 19, 2026

Copy link
Copy Markdown
Member

Thanks! One leftover: compose.yaml is reverted but the README footer still has the Stump Discord link — the README is generated from compose.yaml, so just re-run dbuild generate -- rest looks good

@ahze
ahze merged commit d1cd256 into daemonless:main Jul 19, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants