fix(quality): resolve all 28 repo-level Codacy issues (ESLint8 suppressions + 9 code fixes) - #628
Merged
Merged
Conversation
… ESLint8 config suppressions)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
 |
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| JavaScript |  |
Aug 10, 2026 3:32p.m. | Review ↗ |
| Python | |
Aug 10, 2026 3:32p.m. | Review ↗ |
| Shell | |
Aug 10, 2026 3:32p.m. | Review ↗ |
| SQL | |
Aug 10, 2026 3:32p.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
![deepsource-io[bot]](https://avatars.githubusercontent.com/in/16372?s=60&v=4){kind=small}
Contributor
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 51 |
| Duplication | 1 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
![owl-watch[bot]](https://avatars.githubusercontent.com/u/210417176?s=60&v=4){kind=small}
…n-bounds by construction
…pboard unavailability
Convert the five JS-0067-flagged export function declarations (TrizView, TypeSelector, CommandPalette, useIsMobile, Overlay) to const arrow functions, the AGENTS.md-preferred form, and drop the void operator from the two JS-0098-flagged promise call sites (clipboard write, encrypted export) in favor of .catch(() => undefined), which satisfies Codacy's no-floating-promises rule without the void keyword. DeepSource reported issuesSuppressedCount: 0 for these codes despite the issue_patterns in .deepsource.toml, so the code fix is the primary remedy.
d-oit
enabled auto-merge (squash)
August 10, 2026 15:31
Owner
Author
|
ci: re-evaluate mergeability after review-thread resolution (Plan 098) — reopen immediately |
auto-merge was automatically disabled
August 10, 2026 15:32
Pull request was closed
d-oit
enabled auto-merge (squash)
August 10, 2026 15:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves all 28 repo-level Codacy issues on
main(23 High, 3 Error, 2 Warning) via a mix of real code fixes and false-positive suppressions.Root cause
.codacy.ymldisablesESLint9_-prefixed rules, but Codacy's cloud analysis actually runs the legacy ESLint (v8) engine, which reportsESLint8_-prefixed pattern IDs — so every suppression was silently ineffective. Added aneslint-8engine section with matchingESLint8_suppressions for verified false-positive patterns.Real code fixes (9)
triz-view.tsxvoid ... .catch()+ try/catch (no-floating-promises, no-unnecessary-condition)type-selector.tsx?.on in-bounds NodeList indexcommand-palette.tsxshared-primitives.tsx[0]→.at(0)so?? containerfallback is type-honestform.tsxif (!fieldContext)guard (never null; dereferenced above)use-mobile.tsencrypt-export-dialog.tsxvoid handleExport(...)(no-misused-promises)export-format-grid.tsxself-fix-loop.shFalse positives suppressed (19)
validateOllamaUrl(localhost-only) / protocol +isPrivateIPchecks; added inline// nosemgrepmarkers with justificationxss/no-mixed-html— React JSX components, DOM-node refs, and file downloads (not raw HTML strings executed in DOM)security/detect-object-injection— indexing constant lookup tables (TRIZ_PARAMETERS,BUTTON_VARIANTS) with typed keysno-unnecessary-condition— runtime-defensive optional chaining where the type system is non-nullableValidation
tsc -p tsconfig.app.json --noEmit✓shellcheckonself-fix-loop.sh✓