fix: keep reserved sentinels virtual#197
Open
marcus-pousette wants to merge 1 commit into
Open
Conversation
marcus-pousette
force-pushed
the
fix/order-key-hardening
branch
from
July 12, 2026 11:11
b7024f8 to
1485ca1
Compare
marcus-pousette
force-pushed
the
fix/reserved-sentinel-targets
branch
from
July 12, 2026 11:11
ae24474 to
9f0225b
Compare
marcus-pousette
force-pushed
the
fix/order-key-hardening
branch
from
July 13, 2026 13:21
1485ca1 to
0c7480f
Compare
marcus-pousette
force-pushed
the
fix/reserved-sentinel-targets
branch
from
July 13, 2026 13:21
9f0225b to
87389a6
Compare
marcus-pousette
force-pushed
the
fix/order-key-hardening
branch
from
July 13, 2026 15:04
0c7480f to
7e2c90f
Compare
marcus-pousette
force-pushed
the
fix/reserved-sentinel-targets
branch
from
July 13, 2026 15:19
87389a6 to
4ab15c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ROOTandTRASHare protocol sentinels, but materialization could treat them like application nodes before rejecting an operation. That could create physical sentinel rows, lose former-parent metadata, suppress the first move-to-Trash event, or emit false replay moves.Fix
TRASHare deterministic no-ops.ROOTare deterministic no-ops.Payload(ROOT, ...)remains the supported document-level payload.TRASHwithout creating a TRASH row.Strict input contract
Reserved targets do not bypass #218's structural-key validation. Malformed ROOT/TRASH operations are rejected before no-op handling; only canonical operations reach the sentinel fast path.
There is no old-log exception, schema version, migration marker, row scan, backfill, or upgrade replay. Development databases containing the earlier shape must be recreated.
Fast paths
Size
11 files, +234/-31 relative to #186. Removing the prior compatibility/migration design cut the PR by more than 400 lines.
Verification
cargo test --workspacegit diff --checkStack
Stacked on #186.