Skip to content

return the columns that create data viz in the outlier plot - #57

Open
dendroica wants to merge 1 commit into
ctmm-initiative:masterfrom
dendroica:outlier
Open

return the columns that create data viz in the outlier plot#57
dendroica wants to merge 1 commit into
ctmm-initiative:masterfrom
dendroica:outlier

Conversation

@dendroica

@dendroica dendroica commented May 20, 2024

Copy link
Copy Markdown

suggest adding the columns that weight the blue lines and the points so it is easier to see in the output data frame which points they correspond to

@dendroica dendroica left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I edited this in my own code copy because I found the feature useful to more quickly be able to identify the points being visualized as outliers; I think it might help others find them more quickly too

@chfleming

Copy link
Copy Markdown
Contributor

Thanks @dendroica

For lwd, the values correspond to the n-1 intervals between points and not the n points themselves, and so there is one fewer, which you padded with a zero. I think that could cause confusion to users.

I will probably add a verbose option to turn this on and then change the padding to NA to avoid confusion.

@dendroica

Copy link
Copy Markdown
Author

awesome, thanks for the consideration and good call re: NA value for padding the vector :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants