WmTests: fix natural rotation tests - #1341
Open
CeRRiLLo89 wants to merge 1 commit into
Open
Conversation
CeRRiLLo89
marked this pull request as ready for review
August 3, 2026 12:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getNaturalRotation()method at the three affected test sites instead of referencing it as a value.foldableConfigFalse_locksRotation_usesNaturalRotationdeterministic by configuring the fake settings provider so the current rotation is not eligible.Root cause
The test source referenced
getNaturalRotationwithout invoking it, which preventsWmTestsfrom compiling. After correcting those calls, the natural-rotation test could still selectUSE_CURRENT_ROTATIONbecause the default allowed-rotation mask includes the device's current rotation. SettingACCELEROMETER_ROTATION_ANGLESto0in the fake resolver isolates the natural-rotation branch the test is intended to cover.This changes test code only; no production behavior is modified.
Validation
m -j6 WmTests— passedatest --serial 112eb247 'WmTests:com.android.server.wm.DeviceStateAutoRotateSettingControllerTests#foldableConfigFalse_locksRotation_usesNaturalRotation'— 1 passed, 0 failedatest --serial 112eb247 WmTests:com.android.server.wm.DeviceStateAutoRotateSettingControllerTests— 28 passed, 0 failedValidation device: Xiaomi Mi 9T Pro / Redmi K20 Pro (
raphael), Android 16.