Optimization - #1035
Open
k1o0 wants to merge 3 commits into
Open
Conversation
Sessions and probe insertions REST filters no longer join the datasets table into the main query, which made them 3-174x faster ( went from 194 s to 1.3 s against the production database, and from 112 s to 3.5 s). Adding indexes was measured and rejected: a covering index on is used but only worth ~5% of the remaining query time, and is not worth 153 MB plus the write amplification on a table the ingest pipeline writes to constantly. The remaining cost is one index lookup per tagged dataset to map it to its session; removing that needs the tags denormalised to the session level. Resolves int-brain-lab/iblalyx#143
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.