fix: avoid mutable default for BaseTrainerModel.inference aux_input - #4431
Closed
Solaris-star wants to merge 1 commit into
Closed
fix: avoid mutable default for BaseTrainerModel.inference aux_input#4431Solaris-star wants to merge 1 commit into
Solaris-star wants to merge 1 commit into
Conversation
Replace aux_input={} with Optional[Dict] = None so the abstract
signature does not share a single dict across calls.
Fixes #4427
Signed-off-by: Solaris-star <820622658@qq.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BaseTrainerModel.inferenceused a mutable default (aux_input={}), which is shared across calls at definition time.Use
Optional[Dict] = Noneinstead (Python ≥3.9). Concrete subclasses already useNoneor explicit dict literals in their overrides; this only cleans the abstract base signature.Fixes #4427
Testing
Signature-only change on the abstract base; no runtime path change beyond default construction.