fix: replace 15 bare except clauses with except Exception - #4407
Closed
haosenwang1018 wants to merge 1 commit into
Closed
fix: replace 15 bare except clauses with except Exception#4407haosenwang1018 wants to merge 1 commit into
haosenwang1018 wants to merge 1 commit into
Conversation
Bare `except:` catches BaseException including KeyboardInterrupt and SystemExit. Replaced 15 instances with `except Exception:`.
|
|
Contributor
|
Thank you for the PR! This repo is not maintained anymore. Feel free to send the PR to our fork instead where I can merge it. |
Author
|
CI failures. Closing for rework. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replace 15 bare
except:clauses withexcept Exception:.Why
Bare
except:catchesBaseException, includingKeyboardInterruptandSystemExit, which can prevent clean process shutdown and mask critical errors.