fix: initialize encoding variable before conditional in inference - #4402
Closed
Mr-Neutr0n wants to merge 1 commit into
Closed
fix: initialize encoding variable before conditional in inference#4402Mr-Neutr0n wants to merge 1 commit into
Mr-Neutr0n wants to merge 1 commit into
Conversation
Author
|
closing this out — saw the note about the repo being unmaintained. will redirect to the active fork if still relevant |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AcousticModel.inference(), theencodingvariable was only assigned inside a conditional block (if encoder_outputs_ex.shape[1] > pos_encoding.shape[1]), meaning it would be undefined when the condition isFalse.NameErrorat runtime whenself.decoder()is called withencoding=encoding.encoding = pos_encodingbefore the conditional, so the variable is always initialized regardless of whether the expanded encoder output is longer than the original positional encoding.Test plan
inference()no longer raisesNameErrorwhenencoder_outputs_ex.shape[1] <= pos_encoding.shape[1]True(encoding is still recomputed for the expanded length)