feat(desktop,doctor): scan-to-open QR, network diagnostics, scrollable tool panel - #95
Merged
Merged
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three things: a QR code to open the show on a phone, diagnostics that say why a phone can't, and a Patterns tab that stops eating the grid.
Scan to open (Show route). The bare
LAN: 192.168.…text becomes a popover with a QR of that URL, a copy button, and a picker when the laptop holds several addresses. Nothing is persisted — the URLs come fromBrainStatus.lanUrls(recomputed from live interfaces every status read) and the control isn't rendered while the brain is down. Ordering isrankLanUrls:192.168/16first, then10/8, then172.16/12, with169.254(DHCP never completed) last, so the address a phone is actually on leads instead of a docker bridge.One Electron wrinkle: the laser UI is a native
WebContentsViewstacked above the page, so a popover overlapping it would be invisible. The route hides the view while the QR is open (visible: !sharing) and restores it on close.Network doctor (Status → Advanced, and
wavegrid doctor). The honest answer to "should the LAN URL work on the same wifi?" — the server does bind0.0.0.0, so the URL is real, but a venue/guest network with client isolation blocks it anyway and a laptop cannot prove reachability by itself. So the report separates evidence from inference:The positive evidence is new:
http-app.tsrecords non-loopback HTTP clients into a bounded (20) in-memory map surfaced asSystemStatus.lanVisitors, so "a phone reached the brain" becomes a fact rather than a guess.probeNetworkdrops visitors whose address is one of our own interfaces — a browser on this laptop opening the LAN URL proves nothing. Neighbour discovery shells out toarp -anand reportsneighboursKnown: falsewhen that isn't available, so an unreadable table never reads as "nobody is there".verdictForis pure and tested.runningBind()is new becauseBrainStatus.urlis deliberately the loopback URL the embedded UI loads; diagnostics need the actual bind host.Patterns scroll (
packages/ui). The bottom tool panel had no height cap and no internal scroll, so a tall tab pushed the grid off screen. It's nowmaxHeight: 50%with the content areaflex-1 overflow-y-auto; the right-hand layout is unchanged.Verified against a running show on this box:
doctorprintedproven-reachablefor a real request over the LAN IP, andblocked-locally/unprovenclassifications are covered by tests.pnpm test,pnpm build,pnpm lintall pass.Link to Devin session: https://app.devin.ai/sessions/972698f89f494b86828010666a002b8f
Requested by: @pyramation