fix(channels): preserve unread data on remote close - #257
Merged
Conversation
CHANNEL_CLOSE can arrive while a delivery pump is suspended on a "rendezvous" send or while ingress data remains queued. Cancelling the pump then drops stdout, stderr, extended-data, or forwarding tails (depending on the channel type) and reports a misleading clean EOF. Gracefully drain accepted data after remote closure while keeping caller-requested close and disconnect as an abort. Explicit close also releases pumps retained after remote closure, delayed delivery no longer returns stale window credit, and the state-machine model checks valid inbound-stream closure effects. Add unit and FakeServer coverage for delayed session and forwarding reads, explicit aborts, direct TCP forwarding, and a deterministic 1 MiB multi-window transfer whose final packet remains parked until CLOSE is processed. This should exercise the issues that were being seen without relying on probabalistic tests. Fixes connectbot#245
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANNEL_CLOSE can arrive while a delivery pump is suspended on a "rendezvous" send or while ingress data remains queued. Cancelling the pump then drops stdout, stderr, extended-data, or forwarding tails (depending on the channel type) and reports a misleading clean EOF.
Gracefully drain accepted data after remote closure while keeping caller-requested close and disconnect as an abort. Explicit close also releases pumps retained after remote closure, delayed delivery no longer returns stale window credit, and the state-machine model checks valid inbound-stream closure effects.
Add unit and FakeServer coverage for delayed session and forwarding reads, explicit aborts, direct TCP forwarding, and a deterministic 1 MiB multi-window transfer whose final packet remains parked until CLOSE is processed. This should exercise the issues that were being seen without relying on probabalistic tests.
Fixes #245