Fix missing getWiresLocation() helper method - #219
Conversation
Co-authored-by: grantcopley <1197835+grantcopley@users.noreply.github.com>
Co-authored-by: grantcopley <1197835+grantcopley@users.noreply.github.com>
grantcopley
left a comment
There was a problem hiding this comment.
@copilot I forgot we already have "showProgressBar" and "progressBarColor" configuration settings and I don't want to change them. But check to the code to make sure these settings actually affect the progress bar because I don't believe they are working currently.
…or are already working Co-authored-by: grantcopley <1197835+grantcopley@users.noreply.github.com>
You're absolutely right! The settings The existing settings properly control the wire:navigate progress bar:
The only change I kept was adding the missing Commit: Revert to original setting names - showProgressBar and progressBarColor are already working |
|
@copilot Should we not also call getWiresLocation() here? Double check. |
… logic Co-authored-by: grantcopley <1197835+grantcopley@users.noreply.github.com>
... Good catch! Yes, we should use This ensures both Commit: Use getWiresLocation() helper in getComponentDSL() to avoid duplicate logic |
Fix missing getWiresLocation() helper method
Overview
This PR fixes a bug where
getWiresLocation()was being called inCBWIREController.cfcbut the method didn't exist, which would cause errors when using module component paths.Changes
Bug Fix (CBWIREController.cfc)
getWiresLocation()private helper methodgetComponentDSL()to usegetWiresLocation()instead of duplicating the logicImplementation
The
getWiresLocation()helper method centralizes the logic for determining the wires location:Now used consistently in:
getModuleComponentPath()- For module component path resolutiongetComponentDSL()- For standard component path resolutionThis eliminates code duplication and ensures consistent behavior across both methods.
Note on Progress Bar Settings
The original issue requested adding configuration for wire:navigate progress bar customization. However, these settings already exist and are working correctly:
showProgressBar- Enable/disable the progress bar (default:true)progressBarColor- Customize the progress bar color (default:##2299dd)These settings are properly implemented in:
data-no-progress-barattribute when disabled--livewire-progress-bar-colorUsage (Already Available)
Fixes #170
Original prompt
Fixes #170
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.