Retire the legacy 5h PM-check clock, keep Navid's 10:00/16:00 job - #24
Open
navidshad wants to merge 1 commit into
Open
Retire the legacy 5h PM-check clock, keep Navid's 10:00/16:00 job#24navidshad wants to merge 1 commit into
navidshad wants to merge 1 commit into
Conversation
The scheduler ran its own fixed-interval PM check (PM_CHECK_INTERVAL_MS, default 5h) independently of the agent-owned "pm-check" scheduled job Navid set up on a 10:00/16:00 cron. The two fired on separate clocks and produced several duplicate PM-check-shaped runs a day, flagged repeatedly in chat over the past two weeks. Removing the built-in clock leaves the generic-scheduler job as the only source of scheduled PM checks; manual triggers (CLI, chat "run pm-check") are untouched. Co-Authored-By: Aso Dara <info@codebridger.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PM_CHECK_INTERVAL_MSin scheduler.ts) alongside the generic-scheduler's ownpm-checkcron job (Navid's 10:00 + 16:00 slots). The two overlapped and fired several PM-check-shaped runs a day, spamming DMs and task comments with duplicate content.startScheduler— the generic-schedulerpm-checkjob (the one Navid actually configured) is now the only scheduled source.runPmCheckinrhythms/pmCheck.tsis untouched for manual/chat-triggered runs.Test plan
runPmCheck) still work as before🤖 Generated with Claude Code