Sync upstream Ceph and restore CobaltCore builder - #9
Closed
senolcolak wants to merge 6249 commits into
Closed
Conversation
mgr/dashboard: rgw gateway switcher read-only for resource page Reviewed-by: Afreen Misbah <afreen@ibm.com>
CherryPy's serve_file() uses Python's mimetypes module which returns text/javascript for .js files (RFC 9239), but the gzip config only listed application/javascript. This meant the main Angular bundle was being served uncompressed. With Cheroot write timeouts, the uncompressed transfer times out over slower networks, causing ERR_CONTENT_LENGTH_MISMATCH in the browser. Signed-off-by: Afreen Misbah <afreen@ibm.com>
Normalize persisted hostnames when loading the inventory and host cache so existing clusters continue to work after hostname normalization changes. Centralize hostname normalization in the inventory/cache layer and replace ad-hoc lowercase conversions with normalize_hostname() where appropriate. This keeps hostname handling consistent while avoiding duplicate normalization in higher-level callers. Fixes: https://tracker.ceph.com/issues/78426 Signed-off-by: Shubha Jain <SHUBHA.JAIN1@ibm.com>
Currently most but not all code paths through `radosgw-admin bucket list ...` adhere to the --max-entries command-line parameter. This incorporates that limit to the remaining path. Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
rgw: update rpm and debian builds Reviewed-by: Thomas Serlin <tserlin@redhat.com>
osd: Fix valgrind uninitialized variable issues in fast EC Reviewed-by: Matty Williams <Matty.Williams@ibm.com> Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
osd: Fix PeeringState::proc_lease crash caused by race hazard
osd: Fix race hazard causing duplicated message after OSD marked down
…_desc__c_string common/options: convert `long_desc` to C string
…no_sprintf osd/SnapMapper: use fmt::format() instead of fmt::sprintf()
…y-grow-debug-high-level mgr/ClusterState: remove debug 30 memory spike
Dockerfile.build: install sccache from distro packages when available Reviewed-by: Zack Cerza <zack@redhat.com>
qa/suites/upgrade: ignore expected telemetry warning
mon: allow getpoolstats for mgr modules
tools/rados: fix stdio/stream cleanup
…ush-host mgr: override OSD hostname with CRUSH physical host in all metadata paths
test/crimson/omap: enlarge values under ASan to shrink depth-driven tests Reviewed-by: Kefu Chai <k.chai@proxmox.com>
When editing services such as oauth2-proxy, backend fields like scope arrive as a single string. Spreading that string into the list turned each character into its own row. Normalize string values to one item. Fixes: https://tracker.ceph.com/issues/78808 Signed-off-by: Pedro Gonzalez Gomez <pegonzal@ibm.com>
mgr/dashboard: fix snap schedule startDate Reviewed-by: Afreen Misbah <afreen@ibm.com> Reviewed-by: Nizamudeen A <nia@redhat.com>
ceph-volume: fix nvme preformat wiping VG on osds-per-device > 1
Add RGWHeapProfilerHook to rgw_appmain.cc that registers a "heap" admin socket command, forwarding subcommands to the shared ceph_heap_profiler_handle_command() implementation. This enables heap stats, start_profiler, stop_profiler, dump, release, and release rate commands for RGW via "ceph daemon heap ". Link radosgw against heap_profiler library, update memory-profiling documentation, and add an integration test script. Signed-off-by: Vinayak Tiwari <tiwarivinayak10@gmail.com> Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: Mark Kogan <31659604+mkogan1@users.noreply.github.com>
cephfs-tool: Improve reporting and config options Reviewed-by: Venky Shankar <vshankar@redhat.com>
mgr/dashboard: Add alerts doc url to active alert list Reviewed-by: Aashish Sharma <aasharma@redhat.com>
…mime-type mgr/dashboard: add text/javascript to gzip mime types Reviewed-by: Afreen Misbah <afreen@ibm.com>
Substitutions were not enabled on a prompt directive that tried to use the stable-release substitution so the substitution string was rendered verbatim. Signed-off-by: Ville Ojamo <git2233+ceph@ojamo.eu>
Use ref instead of external link definitions for intra-docs links. Add labels if necessary in files within the install/ directory. Use existing labels for links outside the install/ directory but do not add new labels outside of the install/ directory. Signed-off-by: Ville Ojamo <git2233+ceph@ojamo.eu>
…abel-fix mgr/dashboard: fix cd-text-label-list string writeValue Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Afreen Misbah <afreen@ibm.com>
…ounce Reviewed-by: Afreen Misbah <afreen@ibm.com>
Calling `list_images()` on a non-existent group falsely succeeded and returned an empty iterator.This happened because `Group<I>::image_list` ignored the negative error code returned by `group_image_list`, allowing execution to proceed blindly. Furthermore, the C API `rbd_group_image_list` intercepted `-ENOENT` and forced a success (0) return value. Similarly other public C APIs `rbd_snap_list` and `rbd_group_snap_list` also intercepts -ENOENT and forces a success (0) return value which is incorrect. Fix these behavior by: - Propagating errors properly inside `Group<I>::image_list`. - Removing the incorrect `-ENOENT` masking in `rbd_group_image_list`, `rbd_snap_list`, rbd_group_snap_list` Now `list_images()` consistently raise an `ObjectNotFound` error when invoked on a non-existent group and public C APIs propagate ENOENT without masking it into 0. Also Extended the `TestGroups` test fixture with `self.dne_group` to validate the expected error paths across all relevant APIs. Fixes: https://tracker.ceph.com/issues/78108 Signed-off-by: VinayBhaskar-V <vvarada@redhat.com>
…oved test: Improve efficiency of omap tests Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com> Reviewed-by: Alex Ainscow <aainscow@uk.ibm.com> Reviewed-by: Bill Scales <bill_scales@uk.ibm.com>
* refs/pull/70579/head: doc: v20.2.3 tentacle release notes Reviewed-by: Aviv Caro <Aviv.Caro@ibm.com> Reviewed-by: Patrick Donnelly <pdonnell@ibm.com> Reviewed-by: Afreen Misbah <afreen@ibm.com> Reviewed-by: Adam C. Emerson <aemerson@redhat.com> Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Fixes: 30a3814 Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
Based on my own estimates. Squid will have one more bug fix cycle after v19.2.6. Vampire will release in March. We will likely have 1 or 2 more bug fix cycles before tying it off. Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
rgw: all paths of radosgw-admin bucket list adhere to max-entries Reviewed-by: Oguzhan Ozmen <oozmen@bloomberg.net>
…-fix mgr/cephadm: normalize inventory and host-cache keys at load time to fix upgrade regression Reviewed-by: Adam King <adking@redhat.com>
…_tls mgr/cephadm: include NFS virtual_ip in cephadm-signed cert SANs Reviewed-by: Adam King <adking@redhat.com>
…nt-dead-if-down-post-failover mgr/cephadm: write agent required_files on SSH reconfig Reviewed-by: Shweta Bhosale <Shweta.Bhosale1@ibm.com>
* refs/pull/70849/head: doc/releases: correct v18.2.8 release date Reviewed-by: Yuri Weinstein <yweins@redhat.com>
* refs/pull/70850/head: doc/releases: update EOL dates Reviewed-by: Yuri Weinstein <yweins@redhat.com>
…p-profiler rgw: add tcmalloc heap profiler support via admin socket
tools/contrib: add upmap-remapped.py utility Reviewed-by: Laura Flores <lflores@ibm.com>
doc/ceph-volume: update stale ceph-disk references
doc/radosgw: Remove stale versionadded directives for EOL releases
doc/rados: improve Debugging Slow Requests section
Ceph has required systemd for several release cycles. Remove the "Running Ceph with SysVinit" section from operating.rst and update two other files that still listed sysvinit as a valid init system. - rados/operations/operating.rst: remove the SysVinit section and the stale distribution list in the systemd intro paragraph - ceph-volume/intro.rst: remove "(upstart, sysvinit, etc.)" from the ceph-disk historical context paragraph - start/os-recommendations.rst: remove ``sysvinit`` as an example init framework; systemd is the only supported option Fixes: https://tracker.ceph.com/issues/77187 Signed-off-by: Emmanuel Ameh <eameh@contractor.linuxfoundation.org>
…temd note Remove the ceph-disk migration block from ceph-volume/index.rst as ceph-disk has been deprecated since v13 and ceph-volume is now the assumed standard. Add a note to operating.rst clarifying that systemctl management applies to Podman-based deployments and may differ for Docker.
Prefer devices over disks, tighten the ceph-volume lvm and intro sentences, and say services/might in the systemd section. Signed-off-by: Emmanuel Ameh <eameh@contractor.linuxfoundation.org>
doc: Remove SysVinit/upstart references from user-facing docs
osd/scrubber: send real reservation nonce in scrub grant
…eap-dump mgr/DaemonServer: add heap command to mgr
osd/scrub: exclude non-primary shards from auth_list
mgr/telemetry: fix 500 error when generating telemetry report Reviewed-by: Nizamudeen A <nia@redhat.com>
Signed-off-by: senol.colak <senol.colak@sap.com>
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+465
to
+477
| - id: ptl_audit | ||
| name: Run PTL Audit | ||
| if: steps.router.outputs.run_audit == 'true' | ||
| env: | ||
| PTL_TOOL_GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| PTL_TOOL_REDMINE_API_KEY: ${{ secrets.REDMINE_API_KEY_BACKPORT_BOT }} | ||
| PTL_TOOL_BASE_PROJECT: ${{ github.repository_owner }} | ||
| PTL_TOOL_BASE_REPO: ${{ github.event.repository.name }} | ||
| PTL_TOOL_PR_NUMBER: ${{ github.event.pull_request.number || github.event.issue.number }} | ||
| run: | | ||
| python src/script/ptl-tool.py --debug --ci-mode --audit | ||
|
|
||
| - name: Report Audit Status & Update State Labels |
Collaborator
Author
|
no need for this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Synchronize the fork from the
builderbranch and restore the CobaltCore-owned GitHub files.Build workflow changes
packagesbuild-image variant so RPM builds do not installmake_checkdependencies such as the removedgolang-github-prometheuspackageNPROCandNINJAJOBSinto the build containerslatestCobaltCore files restored
.github/pull_request_template.md.github/workflows/build-ceph-custom.ymlValidation
The workflow is intended for a self-hosted Podman runner and defaults to building
squid-cobaltcoreon CentOS Stream 9.Scope note
builderis the upstream-synchronized branch. This PR therefore includes the upstream source synchronization in addition to the two CobaltCore-owned files.