fix(core): fix Swift account SSRF vulnerability

[TilmanHaupt]

Add input validation to prevent SSRF attacks via Swift account parameter. User-controlled account names can now only be valid AUTH_* format, rejecting absolute URLs, path traversal, and malicious formats.
Part of #1145

Fixes:

• CWE-918: Server-Side Request Forgery
• CWE-200: Information Disclosure

Changes:

• Add Zod schema validation for Swift account parameter
• Validate AUTH_ format with alphanumeric/underscore/hyphen
• Reject HTTP/HTTPS absolute URLs (prevents token theft)
• Reject path traversal attempts (../, ./)
• Add comprehensive security test suite (6 test cases)

Impact:

• Protects 21+ Swift operations accepting account parameter
• No breaking changes to legitimate operations
• Validation runs at input level before API calls

Test coverage: >90% for validation logic
Security: HIGH severity SSRF vulnerability eliminated

Checklist

• I have performed a self-review of my code.
• I have commented my code, particularly in hard-to-understand areas.
• I have added tests that prove my fix is effective or that my feature works.
• New and existing unit tests pass locally with my changes.
• I have made corresponding changes to the documentation (if applicable).
• My changes generate no new warnings or errors.

Summary by CodeRabbit

• Bug Fixes
  • Improved Swift storage account validation to reject unsafe URL, path-traversal, empty, and malformed values.
  • Account values now follow the expected AUTH_<identifier> format and support only letters, numbers, underscores, and hyphens.
  • Empty or omitted account values remain supported.
  • Added safeguards against malicious account inputs that could enable server-side request forgery.

[coderabbitai]

📝 Walkthrough

Walkthrough

The Swift account schema now validates optional account names. It accepts valid AUTH_ formats and omitted or undefined values while rejecting empty strings, URLs, path traversal, and invalid formats. Tests and a changeset document the SSRF protection.

Changes

Swift account validation

Layer / File(s)	Summary
Account schema and validation tests packages/aurora/src/server/Storage/types/swift.ts, packages/aurora/src/server/Storage/types/swift.test.ts, .changeset/swift-account-ssrf-fix.md	baseAccountInputSchema validates optional accounts against the AUTH_<identifier> format. It rejects empty strings, absolute and protocol-relative URLs, metadata-service URLs, path traversal, relative paths, and invalid formats. Tests cover accepted and rejected inputs. The changeset documents the SSRF fix.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: andypf, artiereus, edda

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly identifies the primary change: fixing the Swift account SSRF vulnerability.
Description check	✅ Passed	The description explains the vulnerability, implementation, impact, tests, related issue, and checklist status; missing template sections are non-critical.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch til-sec-2

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Pull request overview

Adds stricter input validation for the optional Swift account parameter in the server-side Zod schemas to mitigate SSRF/path-manipulation risks before Swift API calls are constructed.

Changes:

• Introduces Swift account-name validation logic in the shared base input schema used by multiple Swift operations.
• Adds a focused security test suite for malicious account inputs (URLs, traversal patterns, non-AUTH_ formats).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
packages/aurora/src/server/Storage/types/swift.ts	Adds shared Zod validation for the Swift account parameter to constrain it to AUTH_<identifier>-style values.
packages/aurora/src/server/Storage/types/swift.test.ts	Adds tests covering acceptance/rejection of account inputs for SSRF/traversal protection.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[andypf]

👍

[coderabbitai]

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.