Fix auctioneer tests after bumping the retry interval - #1187
Merged
Conversation
[ai-assisted=yes]
winkingturtle-vmw
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ai-assisted=yes]
Summary
Root cause: commit b387957 changed the auctioneer's lock retry interval from 1s (SQLRetryInterval) to 5s (RetryInterval). This collided with ginkgomon.Runner's hardcoded default StartCheckTimeout of exactly 5 seconds — auctioneer only logs "auctioneer.started" (the test's StartCheck string) after ifrit.Invoke() returns, which blocks until the lock is acquired. When the lock is initially unavailable, the test harness kills the process at t=5s in a race against auctioneer's own first retry attempt (also at t=5s), so the process never got a chance to succeed. This wasn't a hang — the process was being silently SIGKILL'd by the test harness itself, which is why no error or panic ever appeared in the logs.
Fix in auctioneer/cmd/auctioneer/main_test.go:
Backward Compatibility
Breaking Change? No