perf(moq-api): reuse pooled connections for origin lookups - #200
Open
thexeos wants to merge 1 commit into
Open
Conversation
The API client was built with reqwest's defaults, whose 90s pool_idle_timeout closes the pooled connection whenever lookups are spaced further apart than that. Origin lookups sit on the critical path of a subscribe for a namespace the relay does not serve locally, so the next lookup then re-pays a TCP connect and a TLS handshake before the request is sent. Build the client explicitly with a longer idle timeout, a small per-host idle pool, and TCP keepalive so an idle connection is not silently dropped by an intermediary. The public API is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
moq-api's HTTP client is constructed withreqwest::Client::new(), i.e. reqwest's defaults. That includes a 90 secondpool_idle_timeout, so whenever origin lookups are spaced further apart than that, the pooled connection has already been closed and the next lookup pays for a TCP connect and a TLS handshake before the request is even sent. These lookups sit on the critical path of a subscribe for a namespace the relay does not serve locally, which makes those two extra round trips directly user-visible.This builds the client explicitly with a longer idle timeout, a small per-host idle pool, and TCP keepalive so a connection idling in the pool is not silently dropped by a NAT or load balancer. The values are module constants with doc comments, the public API of
Clientis unchanged, and a unit test covers the new construction path.