fix(server-nestjs): protège createUser contre les descriptions GitLab non textuelles - #2584
Merged
Merged
Conversation
Open
10 tasks
shikanime
force-pushed
the
fix/create-user-taken-guard
branch
from
August 26, 2026 10:05
759b8de to
3915fcc
Compare
…descriptions Co-authored-by: Automata <automata@shikanime.studio>
shikanime
force-pushed
the
fix/create-user-taken-guard
branch
from
August 26, 2026 11:57
3915fcc to
937629a
Compare
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
StephaneTrebel
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues liées
#2544
Quel est le comportement actuel ?
createUser(gitlab-client.service.ts:416) teste encoreerror.cause?.description?.includes('has already been taken')directement. Quand GitLab renvoie une erreur de validation, gitbeaker recopie l'objetmessageJSON tel quel danscause.description(typéstringà tort) —.includes is not a function, le TypeError masque la vraie cause. Les trois sites signalés dans #2544 (createGroup,createSubGroup,getOrCreateRepo) utilisent déjàhasGitbeakerCause; ce quatrième appel frère du même fichier avait été manqué.Quel est le nouveau comportement ?
Réutilisation de l'existant :
hasGitbeakerCause(error, 'has already been taken'), même helper que les trois sites déjà corrigés. Une description non textuelle ne crashe plus — l'erreur d'origine est relancée proprement (pas de rattrapage erroné versgetUserByEmail).Test de régression ajouté au bloc existant
describe('createUser'): description objet{ 'project_namespace.name': ['has already been taken'] }→ rejetGitbeakerRequestError, sans fallback email.54/54 tests verts ; tsc sans erreur sur le module.
Cette PR introduit-elle un breaking change ?
Non.