fix(server-nestjs): supprimer les dépôts GitLab orphelins appartenant à la console - #2572
Merged
Conversation
shikanime
force-pushed
the
fix/repo-delete-purge-gate
branch
2 times, most recently
from
August 25, 2026 16:28
dacff8e to
a61e1a6
Compare
…deletion Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr> Change-Id: Ifcb1b14cbb1ab1a250a1f5fa05c619146a6a6964
shikanime
force-pushed
the
fix/repo-delete-purge-gate
branch
from
August 25, 2026 16:29
a61e1a6 to
cd34eee
Compare
shikanime
marked this pull request as ready for review
August 25, 2026 16:29
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
No data about coverage (58.90% Estimated after merge)
shikanime
enabled auto-merge
August 26, 2026 09:21
StephaneTrebel
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues liées
#2533 — symptôme aval : les secrets Vault
-mirrordes dépôts orphelins ne sont jamais détruits (conséquence directe de ce bug).Quel est le comportement actuel ?
La suppression d'un dépôt depuis la console client renvoie
204, mais le dépôt GitLab correspondant reste présent. La réconciliationpurgeOrphanReposne supprimait les dépôts orphelins appartenant à la console (topicplugin-managed) que lorsque le flagpurgeétait explicitement activé ; par défaut elle se contentait de journaliser un avertissement.Quel est le nouveau comportement ?
purgeOrphanRepossupprime désormais de façon inconditionnelle tout dépôt GitLab orphelin portant le topicplugin-managed, indépendamment du flagpurge. Cela aligne la réécriture NestJS sur le comportement du serveur Fastify historique (plugins/gitlab/src/repositories.ts→ensureRepositories, suppression inconditionnelle des excédents). Le flagpurgeconserve son rôle de garde-fou pour le reste de la réconciliation d'ambiance (membres, etc.). Les dépôts système (mirror,infra-apps) ne sont pas concernés car ils ne portent pas le topicplugin-managed.Cette PR introduit-elle un breaking change ?
Non.
Autres informations
apps/server-nestjs/src/modules/repository/repository.controller.ts→RepositoryService.deleteRepository(suppression de la ligne DB puisproject.upsert).apps/server(Fastify, figé) n'est plus celui qui sert l'API v2RepositoriesV2, d'où la correction dansapps/server-nestjs.gitlab.service.spec.tsmis à jour — le cas « purge désactivé » attend désormais la suppression.