fix(client): corrige le lien footer de version en 404 pour les déploiements PR - #2567
Merged
Conversation
shikanime
force-pushed
the
fix/footer-version-link-404
branch
from
August 25, 2026 14:03
40d00c1 to
5515e8d
Compare
shikanime
marked this pull request as ready for review
August 25, 2026 14:03
shikanime
enabled auto-merge
August 25, 2026 14:04
shikanime
force-pushed
the
fix/footer-version-link-404
branch
2 times, most recently
from
August 25, 2026 14:53
b8dc31c to
497adc8
Compare
This was referenced Aug 25, 2026
StephaneTrebel
approved these changes
Aug 26, 2026
StephaneTrebel
left a comment
StephaneTrebel
left a comment
Collaborator
There was a problem hiding this comment.
Mieux qu'avant, assurément 👍
shikanime
force-pushed
the
fix/footer-version-link-404
branch
from
August 26, 2026 12:31
497adc8 to
026a5e0
Compare
The footer hardcoded the releases/tag URL, which 404s for PR deploy labels (pr-<num> shown as vpr-<num>). Map semver tags to their release page, PR labels to the matching pull request, and fall back to the releases index otherwise. Refs #2566
Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr> Change-Id: I042a88ec715b99247c1b3129d4afd3e16a6a6964
shikanime
force-pushed
the
fix/footer-version-link-404
branch
from
August 26, 2026 12:32
026a5e0 to
a09d534
Compare
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
No data about coverage (62.10% Estimated after merge)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues liées
#2566
Quel est le comportement actuel ?
Le footer client lie toujours la version à
https://github.com/cloud-pi-native/console/releases/tag/${appVersion}.En déploiement CI/merge-queue,
APP_VERSIONvautpr-<num>(affichévpr-<num>), étiquette jamais publiée en release : la page renvoie une 404.Quel est le nouveau comportement ?
Le lien est résolu selon la nature de
APP_VERSION:pr-<num>) →https://github.com/cloud-pi-native/console/pull/<num>9.24.4) →https://github.com/cloud-pi-native/console/releases/tag/v9.24.4vpr-dev, valeur inconnue) → indexhttps://github.com/cloud-pi-native/console/releasesCette PR introduit-elle un breaking change ?
Non.
Autres informations
Modification isolée à
apps/client/src/App.vue(un seul fichier, 11 ajouts / 2 suppressions).Le commit
system-settings.controller.tsprésent dans le working tree a été volontairement exclu de cette PR.