chore(server-nestjs): make msw server listen setup consistent across specs - #2522
Closed
shikanime wants to merge 1 commit into
Closed
chore(server-nestjs): make msw server listen setup consistent across specs#2522shikanime wants to merge 1 commit into
shikanime wants to merge 1 commit into
Conversation
…specs Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr> Change-Id: Ie7efad03571b61df1e20a568a3d723086a6a6964
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
No data about coverage (25.30% Estimated after merge)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues liées
N/A — chantier de cohérence interne aux tests.
Quel est le comportement actuel ?
Les 6 specs utilisant msw dans
server-nestjsdéclarent toutes le même cycle de vie (setupServer+listen/resetHandlers/close), maisvault-client.service.spec.tsest la seule à appelerserver.listen()sans option. Les 5 autres (gitlab, keycloak ×4, nexus, registry, sonarqube) passentonUnhandledRequest: 'error', qui fait échouer le test sur toute requête non mockée.Quel est le nouveau comportement ?
vault-client.service.spec.tspasseserver.listen({ onUnhandledRequest: 'error' })comme toutes les autres specs — même garde contre les requêtes non mockées, comportement inchangé sinon (8/8 tests verts).Cette PR introduit-elle un breaking change ?
Non.
Autres informations
Commit unique
0bdbe275, aucun changement fonctionnel : une ligne de setup de test.