Skip to content

Updated NLTK dependency#72

Merged
mounacheikho-cmd merged 2 commits into
climateandtech:maintenance/security-updatesfrom
mounacheikho-cmd:issue-53-nltk-security-patch
Jul 21, 2026
Merged

Updated NLTK dependency#72
mounacheikho-cmd merged 2 commits into
climateandtech:maintenance/security-updatesfrom
mounacheikho-cmd:issue-53-nltk-security-patch

Conversation

@mounacheikho-cmd

Copy link
Copy Markdown
Collaborator

Part of #53.

This updates NLTK dependency.

NLTK is not used directly by the application or tests, so no code changes were needed.

Validation

  • Installed requirements.txt
  • Confirmed NLTK version 3.9.3
  • Ran the test suite: 218 passed, 5 skipped, 20 warnings
  • pip check runs with no issues

@suung suung left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mounacheikho-cmd

I did a quick check and nltk comes from langchain, correct?
If there is no reason to load it on our own, maybe we can remove it if then everything still works.

@mounacheikho-cmd

Copy link
Copy Markdown
Collaborator Author

Hey @mounacheikho-cmd

I did a quick check and nltk comes from langchain, correct? If there is no reason to load it on our own, maybe we can remove it if then everything still works.

you are right, it is already installed through LlamaIndex so I removed the nltk pin. The environment uses nltk 3.10.0, and all tests still pass.

@mounacheikho-cmd
mounacheikho-cmd merged commit 7b986f7 into climateandtech:maintenance/security-updates Jul 21, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants