Detect Star Citizen installs on any drive and custom library folders (C#) - #9
Merged
Merged
Conversation
…(C#) Port the Python detection improvements to the C# (WinForms) app. DetectInstallations previously only checked the fixed layout "<drive>:\Program Files\Roberts Space Industries\StarCitizen" on drives C-G, so an install in a custom library folder (e.g. G:\Games\StarCitizen) was never found. - Scan every fixed drive via DriveInfo, not a hardcoded list. - Cover common custom roots (Games\StarCitizen, bare StarCitizen, etc.). - Read the authoritative install path from the RSI Launcher log (%APPDATA%\rsilauncher\logs\log.log). All candidates are still verified against <env>\logbackups on disk before being offered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the install-detection improvements (PR #7) to the C# / WinForms app for parity.
DetectInstallations()previously checked only<drive>:\Program Files\Roberts Space Industries\StarCitizenacross drives C-G. So even though it scanned G, a custom library folder likeG:\Games\StarCitizenwas never found and the app fell back to "No installations found".Changes (
Form1.cs)DriveInfo.GetDrives()instead of a hardcodedC-Glist.Games\Roberts Space Industries\StarCitizen,Games\StarCitizen, bareStarCitizen, plus the original two.%APPDATA%\rsilauncher\logs\log.log) — the only reliable source for a fully custom library folder.<env>\logbackupson disk, so stale/moved installs are dropped.Verification
/p:TreatWarningsAsErrors=true /p:RunAnalyzersDuringBuild=true) — builds clean, no warnings.G:\Games\StarCitizen(and a staleC:\…entry that is correctly discarded because itslogbackupsno longer exists), yieldingLIVE (G:)— matching the Python implementation.