[UI/#15] 공통 모달 구현 - #16
Merged
Merged
Conversation
WalkthroughZustand 기반 모달 스토어와 공통 Changes공통 모달
Estimated code review effort: 3 (Moderate) | ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🤖 PR Checks 결과
|
There was a problem hiding this comment.
🧹 Nitpick comments (1)
components/common/Modal/Modal.tsx (1)
25-32: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value
ModalProps를 파일 상단으로 이동하세요.
ModalProps를 import와ModalHeaderIcon선언 다음에 배치하세요. 현재 위치는components/**의 props 타입 선언 규칙과 다릅니다.As per path instructions, "props 타입은 파일 상단에 type XxxProps = {} 형태로 선언".
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@components/common/Modal/Modal.tsx` around lines 25 - 32, ModalProps 선언을 Modal.tsx 파일 상단으로 이동하세요. import 문과 ModalHeaderIcon 선언 바로 다음, 컴포넌트 구현보다 앞에 배치하고 현재의 props 필드와 타입은 그대로 유지하세요.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@components/common/Modal/Modal.tsx`:
- Around line 25-32: ModalProps 선언을 Modal.tsx 파일 상단으로 이동하세요. import 문과
ModalHeaderIcon 선언 바로 다음, 컴포넌트 구현보다 앞에 배치하고 현재의 props 필드와 타입은 그대로 유지하세요.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 78e0399d-e338-4839-8159-b212da4451b1
📒 Files selected for processing (5)
app/_layout.tsxcomponents/ModalProvider.tsxcomponents/common/Modal/Modal.stories.tsxcomponents/common/Modal/Modal.tsxstore/modalStore.ts
yewon20804
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈번호
(Closes 키워드가 있어야 PR이 머지되었을 때 이슈가 자동으로 닫힌다)
📌 PR 유형
어떤 변경 사항이 있나요?
📌 PR 요약
공통 모달 UI 컴포넌트와 Zustand 기반 모달 store, 앱 전역에서 모달을 렌더링하는 ModalProvider를 추가했습니다.
📌 작업 세부 내용
모달의 공통 구조를 기준으로
Modal공통 컴포넌트를 추가했습니다.cancel/check헤더 아이콘 옵션ScrollViewchildren으로 조합Storybook에서 모달 UI를 확인할 수 있도록 예시 스토리를 추가했습니다.
Zustand 기반
modalStore를 추가했습니다.modalopenModalcloseModal앱 루트에
ModalProvider를 연결했습니다.Modal렌더링closeModal로 연결📸 스크린샷
🔗 기타 (공유사항)