CFE-4074: Added a new input-type: file - #330
Merged
Merged
Conversation
|
Thank you for submitting a pull request! Maybe @craigcomstock can review this? |
SimonThalvorsen
marked this pull request as draft
August 4, 2026 14:25
SimonThalvorsen
force-pushed
the
ENT4074
branch
from
August 6, 2026 09:41
fc823ae to
af9f529
Compare
SimonThalvorsen
marked this pull request as ready for review
August 6, 2026 10:54
SimonThalvorsen
force-pushed
the
ENT4074
branch
from
August 7, 2026 08:59
af9f529 to
379a416
Compare
larsewi
requested changes
Aug 7, 2026
larsewi
left a comment
larsewi
left a comment
Contributor
There was a problem hiding this comment.
Ticket number looks wrong https://northerntech.atlassian.net/browse/ENT-4074
SimonThalvorsen
force-pushed
the
ENT4074
branch
2 times, most recently
from
August 7, 2026 11:35
62aad2a to
4ceb73a
Compare
SimonThalvorsen
changed the title
larsewi
reviewed
Aug 7, 2026
larsewi
left a comment
larsewi
left a comment
Contributor
There was a problem hiding this comment.
I would like @nickanderson or @olehermanse to review this before we merge
|
|
||
|
|
||
| def _perform_input_step(args, name, destination, prefix): | ||
| def _path_if_already_shipped(path, build_modules, destination): |
Contributor
There was a problem hiding this comment.
So this function both tests if the file is already shipped and computes the if not? It feels a bit messy, but I don't know how to make it better.
SimonThalvorsen
force-pushed
the
ENT4074
branch
from
August 10, 2026 08:28
4ceb73a to
b1e9eae
Compare
larsewi
reviewed
Aug 10, 2026
SimonThalvorsen
force-pushed
the
ENT4074
branch
from
August 10, 2026 12:51
b1e9eae to
e9f7a5c
Compare
Ticket: CFE-4074 Signed-off-by: Simon Halvorsen <simon.halvorsen@northern.tech>
SimonThalvorsen
force-pushed
the
ENT4074
branch
from
August 10, 2026 12:59
e9f7a5c to
c6307da
Compare
larsewi
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: CFE-4074