Centralize http response error handling. Better HTTP error messages.#42
Merged
Conversation
…rall request timeout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our previous HTTP timeout was 15 seconds, we've lowered it to 10 seconds for more responsive failures. Additionally we now have a 5 second TCP dial timeout which should make unreachable hosts fail that much faster. Finally, we centralized all HTTP Client calls in one place, with one TLS transport for simplicity. This allows us to intercept certain errors and provide nicer error messages too (for example in the case of HTTP client timeouts)